Annotation of wikisrc/kyua/import.mdwn, revision 1.8
1.1 jmmv 1: [[!meta title="Kyua: The way into NetBSD"]]
2: [[!toc levels=2]]
4: **Project owner: [Julio Merino](mailto:jmmv@NetBSD.org).**
1.8 ! jmmv 5: **Status: under review by tech-userlevel@ as of 2013-02-01.**
1.1 jmmv 6:
7: The import of Kyua into NetBSD to replace the deprecated ATF tools is
8: planned to happen in NetBSD 7.0. The ATF libraries will remain in place,
9: and as such no changes will happen to the tests that already live in
12: The transition from ATF to Kyua includes steps and tools to offer backwards
13: compatibility with users that may rely on the ATF tools shipped since
14: NetBSD 5.0. These backwards compatibility tools cover the most common use
15: cases but might not be perfect initially. Despite these provisions, this
16: plan should be executed well in advance the creation of the 7.0 branch to
17: ensure there is enough time in NetBSD-current to flesh out any major
1.3 jmmv 20: **Before moving on, please read the
1.2 jmmv 21: [[Kyua: An introduction for NetBSD users|/kyua]] page. You should be
1.1 jmmv 22: familiar with the structure of Kyua and its major components to be able to
1.3 jmmv 23: review this plan.**
1.1 jmmv 24:
25: # Proposed changes
27: The final user visible changes that this project will bring to NetBSD are
28: as follows. Because these change the availability of tools that have
29: already been shipped since 5.0, the modifications are staged to happen
30: across two major releases:
32: ## For NetBSD 7.0
34: * Addition of the new `kyua` command-line tool. This provides the runtime
35: engine for the test programs (`atf-run`'s functionality) and the ability
36: to generate reports of the results in plain text form and HTML form
37: (`atf-report`'s functionality). This tool is able to execute all the
38: existing test programs without modifications.
40: * Replacement of the `Atffile`s files in `/usr/tests` with `Kyuafile`s.
42: * Ability to generate HTML reports right form the base system, with such
43: reports hooked into the various continuous build systems.
45: * Replacement of the `atf-run` and `atf-report` tools with shell scripts
46: that provide backwards compatibility implementations based on `kyua`.
47: These can deal with old-style `Atffile`s so that users with custom test
48: suites can continue to run them.
50: * Introduction of a new `atf2kyua` script to convert old `Atffile`s to
51: `Kyuafile`s. This is used internally by the compatibility `atf-run`
52: script, but can also be invoked by the end user by hand to deal with his
53: own test suites. Could be placed into `libexec` if we do not want to
54: make this public.
56: ## For NetBSD 8.0
58: * Removal of the backwards compatibility `atf-run` and `atf-report`
59: scripts, as well as the supporting `atf2kyua` tool.
1.3 jmmv 61: # Why?
63: As mentioned in [[another page|/kyua]], Kyua should be seen as ATF 2.x even
64: though it carries a different name. It is the evolution of the previous
65: ATF tools (*the tools only*), but written in a more modular and flexible
66: way, and with a more reliable codebase. Therefore, you should consider
67: this project as the update of ATF to a newer version.
69: The `atf-run` and `atf-report` tools have effectively been in maintenance
70: mode for over a year already. None of the desired features (see the list
71: of open PRs) have been implemented on top of them, mostly because doing so
72: is building upon a broken implementation. Additionally, several developers
73: have had to implement their own test results dashboards due to
74: defficiencies in `atf-report`, effectively reinventing the wheel.
76: This update will permit the real removal of the obsolete tools, thus
77: allowing us to build additional features on top of Kyua without having to
78: worry about being compatible with `atf-run` (and thus adjusting this tool
79: to behave in the same manner).
81: Some possible answers to "Why not?" can be found later in this page.
83: ## And why now?
1.1 jmmv 84:
85: Kyua has existed for almost 3 years already, so you may be wondering why
86: this import is being proposed now. The major reasons are:
88: * Since 0.5, Kyua has now feature-parity with ATF. Replacing the ATF tools
89: with Kyua should not introduce functionality regressions.
91: * NetBSD-6 has been branched relatively recently, so we can expect NetBSD-7
92: to be far away enough in the future to provide plenty of time to
93: stabilize Kyua in NetBSD-current.
95: * The existence of the deprecated `atf-run` and `atf-report` tools hinders
96: the development of new features that require changes to the inteface of
97: ATF test programs. As an example: a highly requested feature is the
98: ability to change the timeout settings of the test programs (for the
99: benefit of old, slow platforms); doing this in the ATF codebase is
102: * Some developers continue to add old-style tests to the tree. While this
103: is suboptimal and against the policy dictated by core@, Kyua brings in a
104: mechanism to allow running these tests unmodified (i.e. without adding
105: any ATF calls in their code). This, in turn, will let such developers
106: add their tests more easily, and thus increase the tests coverage.
108: # The plan
110: This section details what the transition plan looks like and an estimate
111: timeline. As all things that depend on free time (opensource software
112: hacking, in this case), take the estimates with a grain of salt.
114: ## Discuss this plan in tech-userlevel@
116: If you are here it's possibly because a review request for this plan has
1.4 jmmv 117: already been published and thus the plan has already begun.
1.1 jmmv 118:
119: This plan will be sent to the tech-userlevel@ mailing list asking for
120: comments. **Two weeks shall be allowed for initial discussion.** Depending
121: on the outcome, the plan and/or the software will need to be adjusted
122: (which in turn may require significant amounts of time not yet accounted
123: for). I'll be optimistic for now.
125: ## Get core@ approval
127: By policy, the import of any new software component into src requires core@
128: approval. Even though this will have been discussed at length in
129: tech-userlevel@ (as per the previous step), the final decider on this issue
130: will be core@. The corollary of this is that, if no consensus can be
131: reached in tech-userlevel@ regarding this plan, core@ will be asked to come
132: up with a decision.
134: If core@ approves the plan, the next steps shall start immediately. If
135: core@ disagrees, core@ will be asked to provide advice on the corrections
136: that should be made before the plan can be approved.
1.4 jmmv 138: It is hard to tell how long this step will last, but possibly account for 2
139: to 4 weeks.
1.5 jmmv 141: ## Address feedback as a new release
143: Publish a new Kyua release that collects all the feedback from the reviews
146: The list of issues to be addressed can be found by querying the
147: [bug tracker](http://code.google.com/p/kyua/issues/list) for the
149: keyword. In particular, the following are the issues that have arisen from
150: the review:
152: * [Issue 40](http://code.google.com/p/kyua/issues/detail?id=40): Provide
1.6 jmmv 153: manpages instead of an info document. **DONE**
1.5 jmmv 154:
1.8 ! jmmv 155: * [Issue 47](http://code.google.com/p/kyua/issues/detail?id=47): Implement
! 156: independent testers, which reduces the amount of C++ code and avoids the
! 157: need of modifying `bsd.dep.mk`. **DONE**
1.1 jmmv 159: ## Import Kyua into src
1.2 jmmv 161: As the [[introductory page to Kyua|/kyua]] describes, Kyua has been
162: available in pkgsrc for a while and can be readily installed and used to
163: run the tests from `/usr/tests`.
1.1 jmmv 164:
165: However, because ATF lives in src, and because NetBSD aims to provide the
166: best environment for testing "out of the box", Kyua should be imported into
167: src just like ATF was. The major reasons for this, as have been explained
168: in the past, are: first, to allow any new deployment of NetBSD to be
169: validated right after installation and continuously afterwards; and,
170: second, to permit the execution of tests during development without having
171: to install any additional software.
173: The specific steps to perform this import are:
175: 1. Import Lutok into `external/bsd/lutok/`. This is a shared library that
176: wraps the native Lua C interface in C++. Lutok was originally part of
177: Kyua, and was split into its own package per the request of some users
178: that found this component useful on its own.
1.8 ! jmmv 180: 1. Import the Kyua testers into `external/bsd/kyua-testers/`. This yields two
! 181: new binaries in `/usr/libexec` (`kyua-atf-tester` and
! 182: `kyua-plain-tester`) and a bunch of tests in `/usr/tests/kyua-testers`.
! 184: 1. Import the Kyua frontend into `external/bsd/kyua-cli/`. This yields a
! 185: new kyua binary in `/usr/bin`, a lot of test programs in
! 186: `/usr/tests/kyua-cli` (around 100) and some auxiliary files in
! 187: `/usr/share/kyua`.
1.1 jmmv 188:
1.6 jmmv 189: 1. Protect all products of Lutok and Kyua with a new `MKKYUA` knob. **Set
190: `MKKYUA=no` by default.** Once the ATF tools are removed, the existence
191: of both the `MKATF` and `MKKYUA` knows will probably be confusing. When
192: that happens, we can revisit this decision by possibly replacing both
193: with an `MKTESTS`.
1.1 jmmv 194:
195: 1. Update `bsd.test.mk` to generate `Kyuafile`s *in addition to*
198: There is no real need to do this import in a branch given that this import
1.6 jmmv 199: only adds new functionality without touching existing stuff, and the new
200: code is disabled by default.
1.1 jmmv 201:
202: All the preparatory work for the import can be done offline (in about two
203: weeks at most, given that I have mot of this ready). Aside from the code
204: changes, this will involve the validation of NetBSD/amd64, NetBSD/i386 and
205: NetBSD/macppc builds (which are the ports I have access to). If you
206: consider that some other tricky architecture should be build-tested
207: (sparc64?), let me know and I'll include it in the list.
1.8 ! jmmv 209: The submission to CVS will be prepared locally and performed on a package
! 210: basis (i.e. `lutok`, `kyua-testers` and `kyua-cli`, in this order). These
! 211: are to be imported separately to simplify the review of the changes and to
! 212: allow me to better test every individual change locally. There may be an
! 213: arbitrary amount of time between the submission of each package: this
! 214: should not be a problem because these modules are still disabled due to
! 215: `MKKYUA` being set to `no` by default.
1.1 jmmv 216:
217: ## Adjust continuous testing systems to use Kyua
219: With `kyua` being part of the release sets, it is possible to adjust the
220: continuous test systems to make use of this tool in the test environments
221: without having to take any additional step.
223: I'll work with gson@ and pgoyette@ to adapt their continuous testing
224: machines to use the new built-in `kyua` binary instead of `atf-run` and
225: `atf-report`. I'm planning to do the necessary work to change `anita`
226: myself, and I expect to help them deploy the changes to their own systems.
227: Because Kyua and ATF will cohexist in the base system at this point,
228: migrating the continuous testing systems to Kyua can happen at its own
231: It might happen that Kyua misses some little detail needed by these
232: systems. In that case, this may require a new release of Kyua and a
233: reimport into the tree. Incremental imports with new features are much
234: easier than the original import described in here. Also, it will be
235: possible to cherry-pick any external changes into the tree without a
236: reimport (as has often been done in ATF).
1.4 jmmv 238: This step can take a few weeks of time, mostly due to the back and forth
239: between different people in different timezones.
1.6 jmmv 241: ## Flip MKKYUA to yet
243: The previous steps imported Kyua but didn't enable its build by default so
244: that proper testing can be performed by the only people that care. Once
245: basic testing (particularly build testing on a variety of platforms) is
246: performed, flip `MKKYUA=yes`.
248: ## Update documentation
250: The [[Kyua: An introduction for NetBSD users|/kyua]] wiki page will be
251: updated to explain how Kyua is bundled in NetBSD and how to use the bundled
254: The [[Creating atf-based tests for NetBSD src|/tutorials/atf]] wiki page
255: will be updated to account for the differences in test programs execution
256: with Kyua instead of ATF.
258: The afterboot(8) and tests(7) manpages will be adjusted to mention `kyua`
259: instead of the ATF tools.
1.1 jmmv 261: ## User validation period
263: At this stage, **at least one month shall be given to the community** to
264: test the new tools and the new test results dashboards. Collect feedback
1.5 jmmv 265: and address requests as appropriate (possibly by releasing and importing a
266: new version of Kyua).
268: One important thing to validate is that the results reported by `atf-run`
269: and `kyua test` match with each other. I have already been validating this
270: with every public release of Kyua, but it has been a manual process. To
271: make this more reliable, I will set up a continuous testing machine of my
272: own in which I will execute `atf-run` and `kyua test` in sequence (possibly
273: within anita) and will add an automatic comparison of the exit status of
274: each other.
1.1 jmmv 275:
1.4 jmmv 276: *Because the old `atf-run` and `atf-report` tools have not yet been dropped
277: at this point, we can spend as much time as necessary on this phase to get
278: things right.*
1.1 jmmv 280: ## Replace atf-run and atf-report with kyua-atf-compat
282: Import the Kyua-based `atf-run` and `atf-report` compatibility tools and
283: stop building the deprecated versions of these. The compatibility versions
284: are shipped in a separate `kyua-atf-compat` package, and thus this will be
285: imported into `external/bsd/kyua-atf-compat/`.
287: Once this is done, change `bsd.test.mk` to not generate `Atffile`s any
288: more, as the compatibility tools do not need them.
290: ## Drop atf-run and atf-report's code
292: Delete the native `atf-run` and `atf-report` utilities from the source tree
293: (and from the upstream repository). This also gets rid of a lot of
294: supporting helper code, which makes the various ATF libraries leaner (and
295: therefore benefits all test programs!).
297: ## Get rid of some ATF wrappers as a proof of concept
299: There are some test programs (e.g. the ones in the ipf test suite) that are
300: not ATF-based. To plug them into the NetBSD test suite, we have
301: implemented ATF-based wrappers that invoke the original plain tests. This
302: is certainly suboptimal, as this level of indirection hinders readability
303: and makes development harder. (In particular, it prevents some key
304: developers from contributing tests in the first place.)
306: Because Kyua has the ability to run these "plain" (non-ATF) test programs
307: directly, and because a bunch of developers are really looking forward to
308: this feature, I will convert a few tests to not include ATF wrappers as a
309: proof of concept of this feature. The ipf tests are probably a good choice
310: for this.
312: ## Remove atf-run and atf-report compatibility tools
314: This is still really far away in the future (needs to happen after NetBSD
315: 7.0 is branched), but I'm listing it for completeness of the plan. The
316: idea is to get rid of any ATF compatibility scripts by NetBSD 8.0. This
317: gives end users a full release cycle (that of 7) to adapt to Kyua while at
318: the same time being able to use the old-style tools.
320: # Possible concerns
322: This section attempts to collect the list of possible concerns and/or
323: objections that may come up during the review, together with an attempt of
324: rebuttal from my side.
326: ## Increased compilation time
328: The addition of any new component to src increases the build time of the
329: whole system. In the case of Kyua, this increase might be noticeable
330: *because of the large amount of test programs provided (roughly 100)*, all
331: of which are in C++.
333: Note that ATF also had a relatively large codebase and a bunch of tests
334: (although not as many). The "trick" was that the majority of these tests
335: were written in shell, and as such they did not increase the build time by
336: much. However, they significantly increased the run time of the test
337: suite, and they were less detailed (mostly integration tests, few unit
338: tests) than the Kyua tests.
340: In order to mitigate this issue, the build of all pieces of Kyua will be
1.5 jmmv 341: protected by `MKKYUA` so that people allergic to C++ can avoid the whole
1.1 jmmv 342: thing. Even more, there are some other additional provisions described
345: ## Introduction of more C++ code in base
347: First of all, why did I use C++? To make the implementation simpler and
348: safer (the RAII programming pattern is really useful in avoiding memory and
349: resource leaks with minimal effort). And C++ is part of the base system
350: and a supported language, so there was no reason not to do so. But that's
1.4 jmmv 351: not the point of this item: if you dislike like C++, this is not going to
352: make you think I did right.
1.1 jmmv 353:
354: It's true that, if we count the number of lines, Kyua brings in more C++
355: code than what will eventually be dropped by the removal of the ATF tools.
356: However, because ATF was also C++, the import of Kyua itself does not make
357: the situation significantly worse.
359: Additionally, the two compilers we can really use (GCC and LLVM) already
360: use, or will soon use, C++ in their code base. It is unlikely that we will
361: be able to remove all C++ support from base anytime soon due to this, while
362: at the same time keeping support for all the ports that NetBSD has.
1.8 ! jmmv 364: Thanks to the
! 365: [testers project](http://code.google.com/p/kyua/wiki/TestersDesign), and
! 366: starting with Kyua 0.6, a lot of the tricky OS-specific code in Kyua has
! 367: been rewritten in plain C. This paves the way to rewriting parts of the
! 368: now-simpler frontend in C or Lua, if the use of C++ proves to be a serious
! 369: problem in the future.
1.7 jmmv 370:
371: In the short term, the replacement of ATF with Kyua does not make things
372: worse: this project just changes one chunk of code with another.
1.1 jmmv 373:
374: ## No need for Lutok as a public library
376: Kyua depends on Lutok, which is a C++ interface to Lua. The code of this
377: library was originally part of Kyua, but I split it into its own project
378: because some users asked for it.
380: If there is no desire to ship Lutok as a shared library in `/usr/lib`, we
381: can build Lutok as a static private library and link Kyua against it.
382: There is no need to install this as a shared library.
CVSweb for NetBSD wikisrc <wikimaster@NetBSD.org> software: FreeBSD-CVSweb